Re: [PATCH 3/3] mmc: sdhci-iproc: add SDHCI_QUIRK2_HOST_OFF_CARD_ON for cygnus

From: Ulf Hansson
Date: Mon May 21 2018 - 06:42:26 EST


On 19 May 2018 at 00:03, Scott Branden <scott.branden@xxxxxxxxxxxx> wrote:
> From: Corneliu Doban <corneliu.doban@xxxxxxxxxxxx>
>
> The SDHCI_QUIRK2_HOST_OFF_CARD_ON is needed for the driver to
> properly reset the host controller (reset all) on initialization
> after exiting deep sleep.
>
> Signed-off-by: Corneliu Doban <corneliu.doban@xxxxxxxxxxxx>
> Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
> Reviewed-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>

Applied for fixes, by adding a fixes+stable tag, thanks!

Fixes: c833e92bbb60 ("mmc: sdhci-iproc: support standard byte
register accesses")
Cc: stable@xxxxxxxxxxxxxxx # v4.10+

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 1f0ab08..d0e83db 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -186,7 +186,7 @@ static const struct sdhci_ops sdhci_iproc_32only_ops = {
>
> static const struct sdhci_pltfm_data sdhci_iproc_cygnus_pltfm_data = {
> .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
> - .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
> + .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN | SDHCI_QUIRK2_HOST_OFF_CARD_ON,
> .ops = &sdhci_iproc_32only_ops,
> };
>
> --
> 2.5.0
>