Re: [v4 09/11] drivers/hwmon: Add PECI cputemp driver

From: Andrew Lunn
Date: Mon May 21 2018 - 16:07:34 EST


> >>+#if IS_ENABLED(CONFIG_X86)
> >>+#include <asm/intel-family.h>
> >>+#else
> >>+#define INTEL_FAM6_HASWELL_X 0x3F
> >>+#define INTEL_FAM6_BROADWELL_X 0x4F
> >>+#define INTEL_FAM6_SKYLAKE_X 0x55
> >>+#endif
> >
> >The entire code is very Intel specific. Why this #if instead of
> >making the driver dependent on X86 ?
> >
>
> This code will be running on ARM kernel at this moment with a purpose
> of monitoring remote x86 CPUs through PECI connection

How about moving what you need from asm/intel-family.h into a header
file in include/linux/. Or move the entire header?

Andrew