Re: [PATCH] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

[Mahadevan, Girish]

Hi Mark,

On 5/17/2018 1:21 AM, Mark Brown wrote:
> On Mon, May 07, 2018 at 02:29:45PM -0600, Mahadevan, Girish wrote:
>> On 5/3/2018 5:38 PM, Mark Brown wrote:
> 
>>> This is a DT based driver but there is no binding documentation.
>>> Binding documentation is required for any new DT stuff.
> 
>> The DT documentation for the SPI driver was done as part of this patch series
>> https://patchwork.kernel.org/patch/10318125/ 
> 
> I can't follow the link as I'm working offline but since I've no record
> of having seen a copy of any bindings for review and I'm fairly sure I'd
> have remembered any bindings without code I'm very disappointed -
> bindings should be being reviewed by the relevant maintainers just like
> code.
> 	
> Fortunately as far as I can tell whereever you sent that to it doesn't
> seem to have been applied but that makes it even more disappointing that
> they're not being sent.
> 

https://patchwork.kernel.org/patch/10318125/
[
Add device tree binding support for the QCOM GENI SE driver.

Signed-off-by: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
Signed-off-by: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
Signed-off-by: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
]

is a patch train for Generic Interface (GENI) based Qualcomm Universal
Peripheral (QUP) wrapper. The wrapper can contain one or more mini cores
that can be used to implement different serial protocols (I2C/SPI/UART).
We'd submitted the DT bindings for that wrapper core and for UART/I2C
drivers which were part of that patch train; but there was a comment to
add the SPI binding document even without the SPI driver (attaching that
email thread).
I can resubmit the SPI binding documentation as part of this patch series.

Best Regards
Girish

> ...
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora
Forum, a Linux Foundation Collaborative Project.

Subject:
Fwd: Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE
From:
Karthik Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
Date:
5/21/2018 10:44 AM
To:
"Mahadevan, Girish" <girishm@xxxxxxxxxxxxxx>




-------- Forwarded Message --------
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree
binding for GENI SE
Date: Tue, 6 Mar 2018 10:13:09 -0700
From: Karthik Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
To: Rob Herring <robh@xxxxxxxxxx>
CC: Jonathan Corbet <corbet@xxxxxxx>, Andy Gross
<andy.gross@xxxxxxxxxx>, David Brown <david.brown@xxxxxxxxxx>, Mark
Rutland <mark.rutland@xxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxxxxx>, Greg
Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx,
linux-arm-msm <linux-arm-msm@xxxxxxxxxxxxxxx>,
devicetree@xxxxxxxxxxxxxxx, Linux I2C <linux-i2c@xxxxxxxxxxxxxxx>,
linux-serial@xxxxxxxxxxxxxxx, Jiri Slaby <jslaby@xxxxxxxx>,
evgreen@xxxxxxxxxxxx, acourbot@xxxxxxxxxxxx, Sagar Dharia
<sdharia@xxxxxxxxxxxxxx>, Girish Mahadevan <girishm@xxxxxxxxxxxxxx>



On 3/6/2018 6:22 AM, Rob Herring wrote:
> > On Mon, Mar 5, 2018 at 6:55 PM, Karthik Ramasubramanian
> > <kramasub@xxxxxxxxxxxxxx> wrote:
>> >>
>> >>
>> >> On 3/5/2018 4:58 PM, Rob Herring wrote:
>>> >>>
>>> >>> On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian
>>> >>> wrote:
>>>> >>>>
>>>> >>>> Add device tree binding support for the QCOM GENI SE driver.
>>>> >>>>
>>>> >>>> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
>>>> >>>> Signed-off-by: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
>>>> >>>> Signed-off-by: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
>>>> >>>> ---
>>>> >>>>    .../devicetree/bindings/soc/qcom/qcom,geni-se.txt  | 89
>>>> >>>> ++++++++++++++++++++++
>>>> >>>>    1 file changed, 89 insertions(+)
>>>> >>>>    create mode 100644
>>>> >>>> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>>>> >>>>
>>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>>>> >>>> b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>>>> >>>> new file mode 100644
>>>> >>>> index 0000000..fe6a0c0
>>>> >>>> --- /dev/null
>>>> >>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>>>> >>>> @@ -0,0 +1,89 @@
>>>> >>>> +Qualcomm Technologies, Inc. GENI Serial Engine QUP Wrapper Controller
>>>> >>>> +
>>>> >>>> +Generic Interface (GENI) based Qualcomm Universal Peripheral (QUP)
>>>> >>>> wrapper
>>>> >>>> +is a programmable module for supporting a wide range of serial
>>>> >>>> interfaces
>>>> >>>> +like UART, SPI, I2C, I3C, etc. A single QUP module can provide upto 8
>>>> >>>> Serial
>>>> >>>> +Interfaces, using its internal Serial Engines. The GENI Serial Engine
>>>> >>>> QUP
>>>> >>>> +Wrapper controller is modeled as a node with zero or more child nodes
>>>> >>>> each
>>>> >>>> +representing a serial engine.
>>>> >>>> +
>>>> >>>> +Required properties:
>>>> >>>> +- compatible:          Must be "qcom,geni-se-qup".
>>>> >>>> +- reg:                 Must contain QUP register address and length.
>>>> >>>> +- clock-names:         Must contain "m-ahb" and "s-ahb".
>>>> >>>> +- clocks:              AHB clocks needed by the device.
>>>> >>>> +
>>>> >>>> +Required properties if child node exists:
>>>> >>>> +- #address-cells:      Must be <1> for Serial Engine Address
>>>> >>>> +- #size-cells:                 Must be <1> for Serial Engine Address
>>>> >>>> Size
>>>> >>>> +- ranges:              Must be present
>>>> >>>> +
>>>> >>>> +Properties for children:
>>>> >>>> +
>>>> >>>> +A GENI based QUP wrapper controller node can contain 0 or more child
>>>> >>>> nodes
>>>> >>>> +representing serial devices.  These serial devices can be a QCOM UART,
>>>> >>>> I2C
>>>> >>>> +controller, spi controller, or some combination of aforementioned
>>>> >>>> devices.
>>> >>>
>>> >>>
>>> >>> s/spi/SPI/
>>> >>>
>>> >>> Where's the SPI binding?
>> >>
>> >> Since the patch series introduces UART and I2C drivers, I added the bindings
>> >> only for them. I thought about adding the SPI binding when the SPI
>> >> controller driver is introduced. Please let me know if you want me to add
>> >> the bindings for SPI in this patch series itself.
> > 
> > There's no requirement to have the driver and I prefer bindings be as
> > complete as possible.
Ok, I will add the bindings for SPI controller in the next posting.
> > 
> > Rob
> > 
Regards,
Karthik.
-- Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project