Re: [PATCH V3 2/3] efi: Introduce efi_queue_work() to queue any efi_runtime_service() on efi_rts_wq

From: Peter Zijlstra
Date: Tue May 22 2018 - 02:42:46 EST


On Mon, May 21, 2018 at 08:13:03PM -0700, Sai Praneeth Prakhya wrote:
> + /* \
> + * queue_work() returns 0 if work was already on queue, \
> + * _ideally_ this should never happen. \
> + */ \
> + if (queue_work(efi_rts_wq, &efi_rts_work.work)) \
> + flush_work(&efi_rts_work.work); \

Since you're _always_ going to wait for it, it is _much_ cheaper to put
a completion in your actual work and wait for that.