Re: [PATCH] tty: add missing const to termios hw-change helper

From: Johan Hovold
Date: Tue May 22 2018 - 03:20:08 EST


On Mon, May 21, 2018 at 06:41:30PM +0200, Greg Kroah-Hartman wrote:
> On Mon, May 21, 2018 at 01:08:44PM +0200, Johan Hovold wrote:
> > Add missing const qualifiers to the termios hw-change helper parameters,
> > which is used by few USB serial drivers. This specifically allows the
> > pl2303 driver to use const arguments in one of its helper as well.
> >
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> >
> > Greg, are you fine with me taking this one through my tree, or do prefer
> > I split out the pl2303 bits?
> >
> > Note that this helper is only used by a few USB serial drivers and that
> > the pl2303 bits depend on a new patch targeted for -next.
>
> Your tree is fine:
>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

I made this patch a prerequisite of the pl2303 change so that I could
use const there from the start instead (i.e. I dropped the pl2303 chunk
from this one).

Now applied.

Thanks,
Johan