Re: [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

[Masahiro Yamada]

2018-05-22 18:06 GMT+09:00 Joey Pabalinas <joeypabalinas@xxxxxxxxx>:
> On Tue, May 22, 2018 at 05:41:48PM +0900, Masahiro Yamada wrote:
>> I see some new motivations for this patch now.
>>
>>   - The current code includes 'Kconfig' in ALLSOURCE_ARCHS,
>>     but it should not.
>>
>>   - Simplify the code, removing the find_all_archs().
>>
>>
>> If you are motivated for v5,
>> how about this?
>>
>>   - Remove the double-quotes from "${tree}arch/"
>>     (Because the rest parts of this script do not have double-quoting,
>>      I do not see point in adding it in this line only.)
>>
>>   - Update the git-log to not mention the hypothetical space things.
>
> Alright, that sounds reasonable. What do you think of:
>
>> ALLSOURCE_ARCHS=$(find ${tree}arch/ -mindepth 1 -maxdepth 1 -type d -printf '%f ')
>
> The double quotes surrounding the arguments have been removed to be more
> consistent with the other find commands in the script.
>
> The ' %f' was changed to '%f ' so that you don't get that weird leading
> space; I couldn't think of a way this could break anything but I wanted
> to be 100% sure instead of needing to make a v6, heh.


Fine with me.







-- 
Best Regards
Masahiro Yamada