Re: [PATCH] tc-testing: flush gact actions on test teardown

From: Shuah Khan
Date: Tue May 22 2018 - 10:49:38 EST


On 05/18/2018 10:21 AM, Vlad Buslov wrote:
> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
> on teardown. Leaking pipe action causes failures in other tests.
>
> Add additional teardown command to also flush gact actions.
>
> Signed-off-by: Vlad Buslov <vladbu@xxxxxxxxxxxx>
> ---
> tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> index 443c9b3..acb24f7 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> @@ -44,7 +44,8 @@
> "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
> "matchCount": "1",
> "teardown": [
> - "$TC actions flush action mirred"
> + "$TC actions flush action mirred",
> + "$TC actions flush action gact"
> ]
> },
> {
>

I can get this into 4.18-rc1 unless there is a reason for this to go
through net tree.

thanks,
-- Shuah