[PATCH] workqueue: move function definitions within CONFIG_SMP block
From: Mathieu Malaterre
Date: Tue May 22 2018 - 14:53:54 EST
In commit 7ee681b25284 ("workqueue: Convert to state machine callbacks"),
three new function definitions were added: âworkqueue_prepare_cpuâ,
âworkqueue_online_cpuâ and âworkqueue_offline_cpuâ.
Move these function definitions within a CONFIG_SMP block since they are
not used outside of it. This will match function declarations in header
<include/linux/workqueue.h>, and silence the following gcc warning (W=1):
kernel/workqueue.c:4743:5: warning: no previous prototype for âworkqueue_prepare_cpuâ [-Wmissing-prototypes]
kernel/workqueue.c:4756:5: warning: no previous prototype for âworkqueue_online_cpuâ [-Wmissing-prototypes]
kernel/workqueue.c:4783:5: warning: no previous prototype for âworkqueue_offline_cpuâ [-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
---
kernel/workqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ca7959be8aaa..c1544225c696 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4579,6 +4579,8 @@ void show_workqueue_state(void)
rcu_read_unlock_sched();
}
+#ifdef CONFIG_SMP
+
/*
* CPU hotplug.
*
@@ -4799,8 +4801,6 @@ int workqueue_offline_cpu(unsigned int cpu)
return 0;
}
-#ifdef CONFIG_SMP
-
struct work_for_cpu {
struct work_struct work;
long (*fn)(void *);
--
2.11.0