Re: [PATCH] drm/omap: dss: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

From: Tomi Valkeinen
Date: Wed May 23 2018 - 04:35:29 EST


On 14/05/18 02:36, HernÃn Gonzalez wrote:
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)).
>
> drivers/gpu/drm/omapdrm/dss/dss.c:959:9-16: WARNING: ERR_CAST can be used with d
> Generated by: scripts/coccinelle/api/err_cast.cocci
>
> Signed-off-by: HernÃn Gonzalez <hernan@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index 0b908e9..be043c8 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -956,7 +956,7 @@ dss_debugfs_create_file(struct dss_device *dss, const char *name,
> &dss_debug_fops);
> if (IS_ERR(d)) {
> kfree(entry);
> - return ERR_PTR(PTR_ERR(d));
> + return ERR_CAST(d);
> }
>
> entry->dentry = d;
>

Thanks, I've picked this up.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki