Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

[Linus Walleij]

On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis <grigoryev@xxxxxxxxxx> wrote:

> The driver stores the result of irq_set_type() in the internal variables
> irq_trig_raise and irq_trig_fall, which later are used to determine
> the GPIOs that must be re-configured as input. These variables retain their
> value between gpiolib's  export / unexport, resulting in an incorrect
> state in some cases. The corresponding bits in the variables
> irq_trig_raise and irq_trig_fall should be cleared in irq_shutdown().
>
> Signed-off-by: Denis Grigoryev <grigoryev@xxxxxxxxxx>

Patch applied with Andy's ACK.

If there are issues we can just revert it.

Yours,
Linus Walleij