Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

From: Marcel Holtmann
Date: Wed May 23 2018 - 07:38:10 EST


Hi Sean,

>>
>> [ ... ]
>>
>>>> - if (hci_dev_test_flag(hdev, HCI_SETUP)) {
>>>> + if (hci_dev_test_flag(hdev, HCI_SETUP) ||
>>>> + test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks)) {
>>>> hci_sock_dev_event(hdev, HCI_DEV_SETUP);
>>>
>>> I am not 100% sure that we want to send the HCI_DEV_SETUP event also multiple times. That is a userspace change that I would need to think about. We need to check create_monitor_event() and see what the btmon trace for this looks like. Can you send me a btmon -w trace.log when this change is active.
>>>
>>> Regards
>>>
>>> Marcel
>>>
>>
>> Sure, I'll send you the trace.log with the change is active.
>>
>> Sean
>>
>
>
> Attached trace.log was captured when I inputted commands power on and
> then off in bluetoothctl.

the trace.log is somehow mangled. Something is not fully correct. Can you read it with btmon -r trace.log?

Regards

Marcel