Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

From: Daniel Lezcano
Date: Wed May 23 2018 - 07:39:05 EST


On 23/05/2018 13:46, Fabio Estevam wrote:
> Hi Daniel,
>
> On Wed, May 23, 2018 at 5:06 AM, Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx> wrote:
>> On 23/05/2018 01:05, Fabio Estevam wrote:
>>> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>>>
>>> Adopt the SPDX license identifier headers to ease license compliance
>>> management.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
>>> ---
>>> drivers/clocksource/timer-imx-gpt.c | 26 ++++++--------------------
>>> 1 file changed, 6 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
>>> index b63b834..165fbbb 100644
>>> --- a/drivers/clocksource/timer-imx-gpt.c
>>> +++ b/drivers/clocksource/timer-imx-gpt.c
>>> @@ -1,23 +1,9 @@
>>> -/*
>>> - * Copyright (C) 2000-2001 Deep Blue Solutions
>>> - * Copyright (C) 2002 Shane Nay (shane@xxxxxxxxxx)
>>> - * Copyright (C) 2006-2007 Pavel Pisa (ppisa@xxxxxxxxxx)
>>> - * Copyright (C) 2008 Juergen Beisert (kernel@xxxxxxxxxxxxxx)
>>> - *
>>> - * This program is free software; you can redistribute it and/or
>>> - * modify it under the terms of the GNU General Public License
>>> - * as published by the Free Software Foundation; either version 2
>>> - * of the License, or (at your option) any later version.
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> - * GNU General Public License for more details.
>>> - *
>>> - * You should have received a copy of the GNU General Public License
>>> - * along with this program; if not, write to the Free Software
>>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
>>> - * MA 02110-1301, USA.
>>> - */
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +//
>>> +// Copyright (C) 2000-2001 Deep Blue Solutions
>>> +// Copyright (C) 2002 Shane Nay (shane@xxxxxxxxxx)
>>> +// Copyright (C) 2006-2007 Pavel Pisa (ppisa@xxxxxxxxxx)
>>> +// Copyright (C) 2008 Juergen Beisert (kernel@xxxxxxxxxxxxxx)
>>
>> Hi Philippe,
>>
>> I went through the code and didn't find any information about the format
>> of the lines following the SPDX, it seems it is relatively free.
>>
>> Can you confirm the above changes are ok ?
>
> Putting everything as // is Linus' preferred style:
> https://lkml.org/lkml/2017/11/25/133

Ok, good. Thanks for the pointer.

I've applied the patches for 4.18.

-- Daniel


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog