Re: [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices

From: Matthew Wilcox
Date: Wed May 23 2018 - 09:33:45 EST


On Wed, May 23, 2018 at 10:20:10AM -0400, Jes Sorensen wrote:
> > +++ b/drivers/pci/pcie/aer/aerdrv_stats.c
> > @@ -0,0 +1,64 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> Fix the formatting please - that gross // gibberish doesn't belong there.

Sorry, Jes. The Chief Penguin has Spoken, and that's the preferred
syntax:

2. Style:

The SPDX license identifier is added in form of a comment. The comment
style depends on the file type::

C source: // SPDX-License-Identifier: <SPDX License Expression>

(you can dig up the discussion around this on the mailing list if you
like. Linus actually thinks that C++ single-line comments are one of
the few things that language got right)