Re: [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping

From: Vaibhav Jain
Date: Wed May 23 2018 - 13:28:44 EST


Michal Suchanek <msuchanek@xxxxxxx> writes:

> When single-stepping kernel code from xmon without a debug hook enabled
> the kernel crashes. This can happen when kernel starts with xmon on
> crash disabled but xmon is entered using sysrq.
>
> Call force_enable_xmon when single-stepping in xmon to install the xmon
> debug hooks.
>
> Fixes: e1368d0c9edb ("powerpc/xmon: Setup debugger hooks when first
> break-point is set")
>
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
LGTM,

Reviewed-by: Vaibhav Jain <vaibhav@xxxxxxxxxxxxx>

--
Vaibhav Jain <vaibhav@xxxxxxxxxxxxx>
Linux Technology Center, IBM India Pvt. Ltd.