Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

From: Laura Abbott
Date: Wed May 23 2018 - 18:00:37 EST


On 05/22/2018 05:33 PM, Andy Lutomirski wrote:
On Tue, May 22, 2018 at 5:19 PM Laura Abbott <labbott@xxxxxxxxxx> wrote:


The vDSO is linked separately from the kernel and modules. Ensure it picks
up the comment section, if available.

Did you end up preferring this to just sticking the kernel version in a
.comment in the vDSO for some reason?


Actually I remember now why this is necessary: there is not a simple way
to encode a string into a linker file as it has to be spit out byte
by byte. The autogeneration was the easiest way to make that happen.
Maybe there's some horrific c preprocessing or other generation that
could happen but I doubt that's any worse than the generated linker
script.

Thanks,
Laura