Re: [PATCH v3 net-next 0/2] bpfilter

[Alexei Starovoitov]

On 5/23/18 6:50 PM, Jakub Kicinski wrote:
> On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote:
> > Minor glitch with Ubuntu 18.04:
> >
> > $ gcc --version
> > gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
> >
> > In file included from /usr/include/fcntl.h:290:0,
> >                  from ../net/bpfilter/main.c:7:
> > In function âopenâ,
> >     inlined from âmainâ at ../net/bpfilter/main.c:58:13:
> > /usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to â__open_missing_modeâ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
> >     __open_missing_mode ();
> >     ^~~~~~~~~~~~~~~~~~~~~~
> > scripts/Makefile.host:107: recipe for target 'net/bpfilter/main.o' failed
> > make[3]: *** [net/bpfilter/main.o] Error 1
> >
> > I can't repro on Fedora 27 gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5),
> > perhaps the GCC is broken on that Ubuntu 18.04 box of mine.  The warning/
> > /error, however, looks potentially legit?
>
> More?
>
> Kernel: arch/x86/boot/bzImage is ready  (#9)
>   Building modules, stage 2.
>   MODPOST 1620 modules
> ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined!
> ../scripts/Makefile.modpost:92: recipe for target '__modpost' failed

hmm. how come buildbot didn't yell at me for any of these things.
will take a look soon.