Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

From: Peter Zijlstra
Date: Thu May 24 2018 - 02:19:15 EST


On Wed, May 23, 2018 at 09:40:47PM -0700, Cong Wang wrote:
> On Wed, May 23, 2018 at 2:09 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > Yeah, don't worry. I hate tracepoints, I regret the existing ones, no
> > new ones will happen.
>
> No matter you hate them or not, they are useful:

No argument there.

> Unlike in sched, tracepoints are welcome in networking:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/include/trace/events/tcp.h

They are also absolutely disallowed in the vfs..

> I don't want to change your mind, just want to show the facts.

The problem with tracepoints is that they can become ABI and you cannot
change them without breaking tools. This is a crap situation and I'm fed
up with it.