Re: [PATCH 2/4] arcnet: com20020: bindings for smsc com20020

From: Rob Herring
Date: Thu May 24 2018 - 09:44:23 EST


On Wed, May 23, 2018 at 5:17 PM, Andrea Greco
<andrea.greco.gapmilano@xxxxxxxxx> wrote:
> On 05/23/2018 06:49 PM, Rob Herring wrote:
>> One typo, otherwise:
>>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Yes typo, Fixed over my branch, sorry for that...
> I expect a comment about bps, Bit per Second, used in `bus-speed-bps`
> You will add it by your self in property-units.txt, or required my patch?

If you want to add it, that's fine. But it's really not something that
comes up often. For UARTs, there's already the "current-speed"
property and most other things I can think of use Hz to express
speeds.

Rob