Re: [PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805

[Guenter Roeck]

On Thu, May 24, 2018 at 09:42:20AM -0700, Ray Jui wrote:
> 
> 
> On 5/24/2018 9:16 AM, Guenter Roeck wrote:
> >On Wed, May 23, 2018 at 05:15:20PM -0700, Ray Jui wrote:
> >>Update the SP805 binding document to add optional 'timeout-sec'
> >>devicetree property
> >>
> >>Signed-off-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
> >>---
> >>  Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >>diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> >>index 0fa3629..1debea3 100644
> >>--- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> >>+++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> >>@@ -19,6 +19,8 @@ Required properties:
> >>  Optional properties:
> >>  - interrupts:  Should specify WDT interrupt number
> >>+- timeout-sec: Should specify default WDT timeout in seconds. If unset, the
> >>+               default timeout in the driver is 30 seconds
> >
> >"... the default timeout is determined by the driver" might be better.
> >If you want to mandate a default here (not sure if that is a good idea),
> >I would suggest to use something like "should be 30 seconds".
> >
> 
> Okay. This can be changed to:
> 
> - timeout-sec: Should specify default WDT timeout in seconds. If unset, the
> default timeout is determined by the driver.
> 
> Please advise how to proceed with this patch series. Should I make the above
> modification and send out v4?

I would suggest to wait a day or two, then send out v4 if there are no further
comments.

Thanks,
Guenter