Re: powerpc: add __printf verification to prom_printf

[Michael Ellerman]

On Fri, 2018-04-06 at 20:12:19 UTC, Mathieu Malaterre wrote:
> __printf is useful to verify format and arguments. Fix arg mismatch
> reported by gcc, remove the following warnings (with W=1):
> 
>   arch/powerpc/kernel/prom_init.c:1467:31: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1471:31: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1504:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1505:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1506:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1507:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1508:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1509:33: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1975:39: error: format â??%luâ?? expects argument of type â??long unsigned intâ??, but argument 2 has type â??unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:1986:27: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:2567:38: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:2567:46: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 3 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:2569:38: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 2 has type â??long unsigned intâ?? [-Werror=format=]
>   arch/powerpc/kernel/prom_init.c:2569:46: error: format â??%xâ?? expects argument of type â??unsigned intâ??, but argument 3 has type â??long unsigned intâ?? [-Werror=format=]
> 
> The patch also include arg mismatch fix for case with #define DEBUG_PROM
> (warning not listed here).
> 
> This patch fix also the following warnings revealed by checkpatch:
> 
>   WARNING: Prefer using '"%s...", __func__' to using 'alloc_up', this function's name, in a string
>   #101: FILE: arch/powerpc/kernel/prom_init.c:1235:
>   + prom_debug("alloc_up(%lx, %lx)\n", size, align);
> 
> and
> 
>   WARNING: Prefer using '"%s...", __func__' to using 'alloc_down', this function's name, in a string
>   #138: FILE: arch/powerpc/kernel/prom_init.c:1278:
>   + prom_debug("alloc_down(%lx, %lx, %s)\n", size, align,
> 
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/eae5f709a4d738c52b6ab636981755

cheers