Re: [v3] powerpc/altivec: Add missing prototypes for altivec

[Michael Ellerman]

On Wed, 2018-03-28 at 18:55:25 UTC, Mathieu Malaterre wrote:
> Some functions prototypes were missing for the non-altivec code. Add the
> missing prototypes in a new header file, fix warnings treated as errors
> with W=1:
> 
>   arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype for â??xor_altivec_2â?? [-Werror=missing-prototypes]
>   arch/powerpc/lib/xor_vmx_glue.c:29:6: error: no previous prototype for â??xor_altivec_3â?? [-Werror=missing-prototypes]
>   arch/powerpc/lib/xor_vmx_glue.c:40:6: error: no previous prototype for â??xor_altivec_4â?? [-Werror=missing-prototypes]
>   arch/powerpc/lib/xor_vmx_glue.c:52:6: error: no previous prototype for â??xor_altivec_5â?? [-Werror=missing-prototypes]
> 
> The prototypes were already present in <asm/xor.h> but this header file is
> meant to be included after <include/linux/raid/xor.h>. Trying to re-use
> <asm/xor.h> directly would lead to warnings such as:
> 
>   arch/powerpc/include/asm/xor.h:39:15: error: variable â??xor_block_altivecâ?? has initializer but incomplete type
> 
> Trying to re-use <asm/xor.h> after <include/linux/raid/xor.h> in
> xor_vmx_glue.c would in turn trigger the following warnings:
> 
>   include/asm-generic/xor.h:688:34: error: â??xor_block_32regsâ?? defined but not used [-Werror=unused-variable]
> 
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/7cf76a68f1bcf69214da2812e8f615

cheers