RE: [PATCH, net-next] net/mlx5e: fix TLS dependency

[Boris Pismenny]

Acked-by: Boris Pismenny <borisp@xxxxxxxxxxxx>

Thank you.

> -----Original Message-----
> From: Saeed Mahameed
> Sent: Saturday, May 26, 2018 2:19 AM
> To: davem@xxxxxxxxxxxxx; arnd@xxxxxxxx; leon@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Boris
> Pismenny <borisp@xxxxxxxxxxxx>; Or Gerlitz <ogerlitz@xxxxxxxxxxxx>;
> Feras Daoud <ferasda@xxxxxxxxxxxx>; Ilan Tayari <ilant@xxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; Ilya Lesokhin <ilyal@xxxxxxxxxxxx>
> Subject: Re: [PATCH, net-next] net/mlx5e: fix TLS dependency
> 
> On Fri, 2018-05-25 at 23:36 +0200, Arnd Bergmann wrote:
> > With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In
> > function `mlx5e_tls_handle_ooo':
> > tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record'
> > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In
> > function `mlx5e_tls_handle_tx_skb':
> > tls_rxtx.c:(.text+0x9a8): undefined reference to
> > `tls_device_sk_destruct'
> >
> > This narrows down the dependency to only allow the configurations that
> > will actually work. The existing dependency on TLS_DEVICE is not
> > sufficient here since MLX5_EN_TLS is a 'bool' symbol.
> >
> > Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> 
> LGTM
> 
> Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>
> 
> Thank you Arnd!
> 
> 
> >  drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > index ee6684779d11..2545296a0c08 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > @@ -91,6 +91,7 @@ config MLX5_EN_TLS
> >  	bool "TLS cryptography-offload accelaration"
> >  	depends on MLX5_CORE_EN
> >  	depends on TLS_DEVICE
> > +	depends on TLS=y || MLX5_CORE=m
> >  	depends on MLX5_ACCEL
> >  	default n
> >  	---help---