Re: [PATCH 4.14 102/496] drm/exynos: g2d: Delete an error message for a failed memory allocation in two functions

[Joe Perches]

On Mon, 2018-05-28 at 11:58 +0200, Greg Kroah-Hartman wrote:
> 4.14-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

I still wonder why any Markus Elfring patch should
be applied to a stable branch.

The only reason I could believe is it would make
forward porting of an actually useful fix easier.

Does this?


> [ Upstream commit 6f0a60298bbbea43ab5e3955913ab19c153076f3 ]
> 
> Omit an extra message for a memory allocation failure in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_g2d.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -286,7 +286,6 @@ static int g2d_init_cmdlist(struct g2d_d
>  
>  	node = kcalloc(G2D_CMDLIST_NUM, sizeof(*node), GFP_KERNEL);
>  	if (!node) {
> -		dev_err(dev, "failed to allocate memory\n");
>  		ret = -ENOMEM;
>  		goto err;
>  	}
> @@ -1358,10 +1357,9 @@ int exynos_g2d_exec_ioctl(struct drm_dev
>  		return -EFAULT;
>  
>  	runqueue_node = kmem_cache_alloc(g2d->runqueue_slab, GFP_KERNEL);
> -	if (!runqueue_node) {
> -		dev_err(dev, "failed to allocate memory\n");
> +	if (!runqueue_node)
>  		return -ENOMEM;
> -	}
> +
>  	run_cmdlist = &runqueue_node->run_cmdlist;
>  	event_list = &runqueue_node->event_list;
>  	INIT_LIST_HEAD(run_cmdlist);
> 
>