Re: [PATCH v5 01/10] sched/pelt: Move pelt related code in a dedicated file
From: Quentin Perret
Date: Tue May 29 2018 - 04:22:02 EST
On Friday 25 May 2018 at 18:14:23 (+0200), Peter Zijlstra wrote:
> On Fri, May 25, 2018 at 03:26:48PM +0100, Quentin Perret wrote:
> > (both quite old TBH -- 4.9.4 for arm64, 4.8.4 for x86).
>
> You really should try with a more recent compiler.
Right, so I just gave it a try for x86 with gcc 8.0.1 (which seem to
introduce a lot of LTO-related enhancements) and I get the following:
Without patch
text data bss dec hex filename
17474129 4980348 995532 23450009 165d199 vmlinux
With patch
text data bss dec hex filename
17474049 4980348 995532 23449929 165d149 vmlinux
So it is still true that this patch actually changes the code size, most
likely because of new function calls. But maybe we don't care if the
impact on performance isn't noticeable ... As Patrick said, a hackbench
run should be more interesting here. I'll give a try later today.
Thanks,
Quentin