Re: [PATCH v1 1/2] dt-binding: hwmon: Add NPCM7xx PWM documentation

[Guenter Roeck]

On Tue, May 29, 2018 at 01:02:20PM +0300, Tomer Maimon wrote:
> Added device tree binding documentation for Nuvoton BMC
> NPCM7xx Pulse Width Modulation (PWM) controller.
> 

As mentioned in the other commit, this should be a pwm driver,
not a hwmon driver.

Guenter

> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
>  .../devicetree/bindings/hwmon/npcm7xx-pwm.txt      | 25 ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/npcm7xx-pwm.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/npcm7xx-pwm.txt b/Documentation/devicetree/bindings/hwmon/npcm7xx-pwm.txt
> new file mode 100644
> index 000000000000..2d8a7ccdc8cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/npcm7xx-pwm.txt
> @@ -0,0 +1,25 @@
> +Nuvoton NPCM7xx Pulse-width modulation (PWM) controller device driver
> +
> +The NPCM7xx has two identical PWM controller modules,
> +Each module has four PWM controller outputs.
> +NPCM7xx PWM controller module 0 outputs PWM0-3 and NPCM7xx PWM controller
> +module 1 outputs PWM4-7.
> +
> +Required properties:
> +- compatible	: "nuvoton,npcm750-pwm" for Poleg NPCM7XX.
> +- reg		: Offset and length of the registers set for the device.
> +- clocks	: phandle of pwm reference clock.
> +- pinctrl-names	: a pinctrl state named "default" must be defined.
> +- pinctrl-0 	: phandle referencing pin configuration of the PWM ports.
> +
> +pwm:pwm@f0103000 {
> +	compatible = "nuvoton,npcm750-pwm";
> +	reg = <0xf0103000 0x50
> +		0xf0104000 0x50>;
> +	clocks = <&clk NPCM7XX_CLK_APB3>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm0_pins &pwm1_pins
> +			&pwm2_pins &pwm3_pins
> +			&pwm4_pins &pwm5_pins
> +			&pwm6_pins &pwm7_pins>;
> +};
> -- 
> 2.14.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html