RE: [PATCH 2/3 V2] x86/mce: Fix incorrect "Machine check from unknown source" message

From: Luck, Tony
Date: Tue May 29 2018 - 13:50:57 EST


> It is still assigning.

Ah. That would be because I forgot to "git add" before "git commit --amend" :-(

> I'll simply do:
>
> if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3) {
> mce_severity(&m, cfg->tolerant, &msg, true);
> mce_panic("Local fatal machine check!", &m, msg);
> }
>
> when committing.

I had put:

(void) mce_severity(&m, cfg->tolerant, &msg, true);

but either works.

> Btw, I did some cleaning up ontop. Please have a look and let me know if
> it is too ugly to live... :)
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=rc7%2b0-ras

Will look. I hope you didn't do too much to make the stable backport more difficult.

-Tony