Re: [PATCH RESEND] time: Fix sleeptime injection for non-stop clocksource & persistent clock
From: John Stultz
Date: Tue May 29 2018 - 22:20:54 EST
On Tue, May 29, 2018 at 2:49 AM, Mukesh Ojha <mojha@xxxxxxxxxxxxxx> wrote:
> Currently, for both non-stop clocksource and persistent clock
> there is a corner case, when a driver failed to go suspend mode
> rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume()
> returned 'false' due to which we can see mismatch in time between
> system clock and other timers.
>
> Success case:
> {sleeptime_injected=true}
> rtc_suspend() => timekeeping_suspend() => timekeeping_resume() =>
> rtc_resume()
>
> Failure case:
> {failure in sleep path} {sleeptime_injected=false}
> rtc_suspend() => rtc_resume()
>
> Signed-off-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>
I'm not sure this patch makes sense yet (since I don't really see how
its used - mind cc'ing me on the patch that makes use of this?)
And more problematic, the patch doesn't seem to apply to mainline.
Could you respin and resend?
thanks
-john