Re: [PATCH 10/19 v3] regulator: s2mps11: Pass descriptor instead of GPIO number

[Linus Walleij]

On Mon, May 28, 2018 at 2:26 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, May 28, 2018 at 2:29 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@xxxxxxxxxxx> wrote:
>
>> -       s2mps11->ext_control_gpiod = devm_kmalloc(&pdev->dev,
>> +       s2mps11->ext_control_gpiod = devm_kzalloc(&pdev->dev,
>>                         sizeof(*s2mps11->ext_control_gpiod) * rdev_num,
>>                         GFP_KERNEL);
>
> devm_kcalloc() I would rather use.

The patch replace kmalloc with kzalloc amd kcalloc does not initialize
memory to zero.

We don't have demv_kzcalloc() I'm afraid, I wonder it even makes
sense to add?

Yours,
Linus Walleij