Re: [PATCH] mm: dmapool: Check the dma pool name

From: Matthew Wilcox
Date: Wed May 30 2018 - 08:01:48 EST


On Wed, May 30, 2018 at 07:28:43PM +0800, Baolin Wang wrote:
> It will be crash if we pass one NULL name when creating one dma pool,
> so we should check the passing name when copy it to dma pool.

NAK. Crashing is the appropriate thing to do. Fix the caller to not
pass NULL.

If you permit NULL to be passed then you're inviting crashes or just
bad reporting later when pool->name is printed.