Re: [PATCH] btrfs: raid56: Remove VLA usage

From: Kees Cook
Date: Wed May 30 2018 - 16:50:03 EST


On Wed, May 30, 2018 at 9:08 AM, David Sterba <dsterba@xxxxxxx> wrote:
> On Wed, May 30, 2018 at 05:14:56PM +0200, David Sterba wrote:
>> On Tue, May 29, 2018 at 04:44:59PM -0700, Kees Cook wrote:
>> > In the quest to remove all stack VLA usage from the kernel[1], this
>> > allocates the working buffers during regular init, instead of using stack
>> > space. This refactors the allocation code a bit to make it easier
>> > to review.
>> >
>> > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx
>
> For the record, so this was the last use of VLA in fs/btrfs/ .

Correct. And fs/ntfs/ has the last remaining VLAs in fs/.

-Kees

--
Kees Cook
Pixel Security