Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

[Arnd Bergmann]

On Mon, May 14, 2018 at 10:06 AM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:


> @@ -892,6 +902,7 @@ static void __init e680_init(void)
>
>         pxa_set_keypad_info(&e680_keypad_platform_data);
>
> +       gpiod_add_lookup_table(&camera_supply_gpiod_table);
>         pwm_add_table(ezx_pwm_lookup, ARRAY_SIZE(ezx_pwm_lookup));
>         platform_add_devices(ARRAY_AND_SIZE(ezx_devices));
>         platform_add_devices(ARRAY_AND_SIZE(e680_devices));
> @@ -1098,7 +1109,7 @@ static struct i2c_board_info __initdata a910_i2c_board_info[] = {
>
>  static struct platform_device *a910_devices[] __initdata = {
>         &a910_gpio_keys,
> -       &camera_supply_dummy_device,
> +       &camera_supply_regulator_device,
>  };
>

This part is wrong and triggered a build warning: camera_supply_gpiod_table
should have been in a910_init(), not e680_init(). I sent a fixup with subject
"ARM: pxa, regulator: fix building ezx e680".

        Arnd