Re: [PATCH v4 4/5] clocksource: add driver for i.MX EPIT timer

[Vladimir Zapolskiy]

Hi ClÃment,

On 05/30/2018 03:03 PM, ClÃment PÃron wrote:
> From: Colin Didier <colin.didier@xxxxxxxxxxxx>
> 
> Add driver for NXP's EPIT timer used in i.MX 6 family of SoC.
> 
> Signed-off-by: Colin Didier <colin.didier@xxxxxxxxxxxx>
> Signed-off-by: ClÃment Peron <clement.peron@xxxxxxxxxxxx>
> ---

[snip]

> +++ b/drivers/clocksource/timer-imx-epit.c
> @@ -0,0 +1,281 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * i.MX EPIT Timer
> + *
> + * Copyright (C) 2010 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> + * Copyright (C) 2018 Colin Didier <colin.didier@xxxxxxxxxxxx>
> + * Copyright (C) 2018 ClÃment PÃron <clement.peron@xxxxxxxxxxxx>
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/clockchips.h>
> +#include <linux/err.h>

The included header above still can be removed.

I have no more comments about the code, I will try to find time to
test the driver, but please don't take it as a promise.

--
With best wishes,
Vladimir