Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

[Timur Tabi]

On 5/31/18 6:53 AM, Sebastian Gottschall wrote:
> >
> i checked initially 4.9 with latest patches and 4.14 and reverted this 
> line to get back to the old behaviour but a which view in the current 
> 4.17ÂtreeÂshows
> that the same patch has been included in 4.17. it was introduced in the 
> kernelÂmainlineÂonÂ12.febÂ2018
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/qcom/pinctrl-msm.c?h=v4.17-rc7&id=a7aa75a2a7dba32594291a71c3704000a2fd7089

I believe that this patch should not be applied to *any* stable kernel.

It completely breaks legacy GPIO numbering, and it does so 
intentionally.  That may be okay for future kernels, but IMHO it's wrong 
for older kernels.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.