Re: [PATCHv2 0/2] Add new SEV commands

[Gary R Hook]

On 05/31/2018 01:45 AM, Herbert Xu wrote:
> On Wed, May 30, 2018 at 01:44:12PM -0500, Gary R Hook wrote:
> > On 05/30/2018 11:28 AM, Herbert Xu wrote:
> > > On Fri, May 25, 2018 at 03:23:28PM -0500, Janakarajan Natarajan wrote:
> > > > This patchset adds two new SEV commands, introduced in SEV API v0.15
> > > > and v0.16 respectively.
> > > >
> > > > * DOWNLOAD_FIRMWARE allows the SEV firmware to be updated if a blob newer
> > > >     than or similar to the exisiting build is available.
> > > >
> > > > * GET_ID allows to query for a unique ID that can be used to retrieve the
> > > >     Chip Endorsment Key (CEK) public key signed by the AMD SEV Signing Key
> > > >     (ASK).
> > > >
> > > > v1->v2:
> > > > * Added cover letter.
> > > > * Misc changes based on Boris' feedback.
> > > >
> > > > Janakarajan Natarajan (2):
> > > >     crypto: ccp: Add DOWNLOAD_FIRMWARE SEV command
> > > >     crypto: ccp: Add GET_ID SEV command
> > > >
> > > >    drivers/crypto/ccp/psp-dev.c | 143 ++++++++++++++++++++++++++++++++++++++++---
> > > >    drivers/crypto/ccp/psp-dev.h |   4 ++
> > > >    include/linux/psp-sev.h      |  23 +++++++
> > > >    include/uapi/linux/psp-sev.h |  12 ++++
> > > >    4 files changed, 172 insertions(+), 10 deletions(-)
> > >
> > > All applied.  Thanks.
> >
> > Huh. Without a Reviewed-by or an Acked-by?
>
> These patches have been out there for weeks.  If you were going
> to object you should have done so by now.

Oh, yes, agreed. This was a question about protocol, not the patches 
themselves. But if you're happy, I'm happy.

Thanks.