Re: [PATCH] PCI: Check for PCIe downtraining conditions

From: Sinan Kaya
Date: Thu May 31 2018 - 11:30:35 EST


On 5/31/2018 11:05 AM, Alexandru Gagniuc wrote:
> + if (dev_cur_speed < max_link_speed)
> + pci_warn(dev, "PCIe downtrain: link speed is %s (%s capable)",
> + pcie_bus_speed_name(dev_cur_speed),
> + pcie_bus_speed_name(max_link_speed));
> +

Also this isn't quite correct. Target link speed is what the device tries to
train. A device can try to train to much lower speed than the maximum on purpose.

It makes sense to print this if the speed that platform wants via target link
speed is different from what is actually established though.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.