Re: [PATCH v2 19/21] bcache: use match_string() helper

From: Coly Li
Date: Fri Jun 01 2018 - 01:05:36 EST


On 2018/6/1 12:32 PM, Yisheng Xie wrote:
> Hi Coly,
>
> On 2018/6/1 11:45, Coly Li wrote:
>> On 2018/5/31 7:11 PM, Yisheng Xie wrote:
>>> match_string() returns the index of an array for a matching string,
>>> which can be used instead of open coded variant.
>>>
>>> Cc: Kent Overstreet <kent.overstreet@xxxxxxxxx>
>>> Cc: linux-bcache@xxxxxxxxxxxxxxx
>>> Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
>>
>> Hi Yishenng,
>>
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> submitted a patch to
>> replace the whole bch_read_string_list() with __sysfs_match_string().
>> And this patch is applied in Jens' block tree, will go into mainline
>> kernel in v4.18.
>>
>> If you search bcache mailing list, you may find a patch named with
>> "bcache: Replace bch_read_string_list() by __sysfs_match_string()".
>>
>> That means this patch will conflict with existing changes.
>
> Get it, and thanks for this information.
>
> Sorry Andy, for doing this once more.
>
Hi Yisheng,

Thank you for the effort, hope to see more bcache patches from you :-)

Coly Li