Re: [PATCH] netfilter: nft_numgen: fix ptr_ret.cocci warnings

From: Pablo Neira Ayuso
Date: Fri Jun 01 2018 - 03:46:57 EST


On Thu, May 24, 2018 at 12:40:04PM +0200, Laura Garcia wrote:
> On Wed, May 23, 2018 at 12:58 PM, kbuild test robot
> <fengguang.wu@xxxxxxxxx> wrote:
> > From: kbuild test robot <fengguang.wu@xxxxxxxxx>
> >
> > net/netfilter/nft_numgen.c:117:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: d734a2888922 ("netfilter: nft_numgen: add map lookups for numgen statements")
> > CC: Laura Garcia Liebana <nevola@xxxxxxxxx>
> > Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>
> Acked-by: Laura Garcia Liebana <nevola@xxxxxxxxx>

Applied, thanks.