Re: [PATCH v3] PCI: mediatek: Add system pm support for MT2712
From: Andy Shevchenko
Date: Fri Jun 01 2018 - 06:52:50 EST
On Fri, Jun 1, 2018 at 1:49 PM, Honghui Zhang
<honghui.zhang@xxxxxxxxxxxx> wrote:
> On Fri, 2018-06-01 at 13:17 +0300, Andy Shevchenko wrote:
>> On Fri, Jun 1, 2018 at 6:04 AM, <honghui.zhang@xxxxxxxxxxxx> wrote:
>> > From: Honghui Zhang <honghui.zhang@xxxxxxxxxxxx>
>>
>> > +#ifdef CONFIG_PM_SLEEP
>> > +static int mtk_pcie_suspend_noirq(struct device *dev)
>>
>> __maybe_unused
>>
>
> Hi, Andy, thanks for your review.
> Bjorn had point this out that at:
> https://www.spinics.net/lists/arm-kernel/msg656774.html
Nice, one more maintainer with strong opinion here.
Arnd, that's what I mentioned as a split in opinions earlier.
Any new developer or even existing contributor would be now really
confusing since maintainers asked for two different approaches on the
same matter.
--
With Best Regards,
Andy Shevchenko