Re: [PATCH] x86/MCE: Get microcode revision from cpu_info instead of boot_cpu_data
From: Borislav Petkov
Date: Fri Jun 01 2018 - 08:42:54 EST
On Fri, Jun 01, 2018 at 12:32:02PM +0000, Sironi, Filippo wrote:
> I've that patch in my tree already, I can post it.
> I'm still curious on why you'd prefer to use boot_cpu_data for all
> CPUs instead of using cpu_data(m->extcpu) though.
Well, for starters, boot_cpu_data having stale revision is a bug in
itself already. So fixing that is already the Right Thing(tm) to do.
Then, one fine day when the whole cpu_data mess is cleaned up,
boot_cpu_data will morph into the global descriptor representing CPU
features and keeping it uptodate now will facilitate the replacement
without introducing bugs.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--