Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback

From: Sinan Kaya
Date: Fri Jun 01 2018 - 09:34:13 EST


On 5/30/2018 9:08 PM, okaya@xxxxxxxxxxxxxx wrote:
> I have seen that shutdown() is also called from remove().
>
> remove() is supposed to do a safe cleanup too. If it is leaving the hw in inconsistent state even though it is c lling shutdown , it is yet another bug.

Let's try to be constructive. I'll post a patch with the pci_disable added to shutdown
only as in my original proposal.

Somebody can deal with remove another day.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.