Re: [PATCH] qtnfmac: fix NULL pointer dereference
From: Gustavo A. R. Silva
Date: Fri Jun 01 2018 - 10:46:37 EST
Hi Sergey,
On 06/01/2018 09:08 AM, Sergey Matyukevich wrote:
Hello Gustavo,
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index 220e2b7..ae0ca80 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -654,8 +654,7 @@ qtnf_disconnect(struct wiphy *wiphy, struct net_device *dev,
vif = qtnf_mac_get_base_vif(mac);
if (!vif) {
pr_err("MAC%u: primary VIF is not configured\n", mac->macid);
- ret = -EFAULT;
- goto out;
+ return -EFAULT;
}
if (vif->wdev.iftype != NL80211_IFTYPE_STATION) {
That was my fault. Thanks for the fix!
Glad to help. :)
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxx>
Thanks
--
Gustavo