Re: powerpc/prom: Fix %u/%llx usage since prom_printf() change
From: Michael Ellerman
Date: Fri Jun 01 2018 - 11:55:20 EST
On Tue, 2018-05-29 at 19:20:01 UTC, Mathieu Malaterre wrote:
> In commit eae5f709a4d7 ("powerpc: Add __printf verification to
> prom_printf") __printf attribute was added to prom_printf(), which
> means GCC started warning about type/format mismatches. As part of that
> commit we changed some "%lx" formats to "%llx" where the type is
> actually unsigned long long.
>
> Unfortunately prom_printf() doesn't know how to print "%llx", it just
> prints a literal "lx", eg:
>
> reserved memory map:
> lx - lx
> lx - lx
>
> prom_printf() also doesn't know how to print "%u" (only "%lu"), it just
> print a literal "u", eg:
>
> Max number of cores passed to firmware: u (NR_CPUS = 2048)
>
> instead of:
>
> Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
>
> This commit adds support for the missing formatters.
>
> Fixes: eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8af1da40669609707303eecdb857f4
cheers