Re: [PATCH v2] fs: ocfs2: Adding new return type vm_fault_t
From: Andrew Morton
Date: Fri Jun 01 2018 - 19:50:37 EST
On Wed, 23 May 2018 21:02:58 +0530 Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> vmf_error() is the newly introduce inline function
> in 4.18.
>
> Fix one checkpatch.pl warning by replacing BUG_ON()
> with WARN_ON()
err, no, I'll revert that part.
It could be that if this assertion triggers then filesystem corruption
would ensue, in which case a BUG_ON() is the appropriate handling.
Such a change should be submitted separately, please.
--- a/fs/ocfs2/mmap.c~fs-ocfs2-adding-new-return-type-vm_fault_t-fix
+++ a/fs/ocfs2/mmap.c
@@ -120,7 +120,7 @@ static vm_fault_t __ocfs2_page_mkwrite(s
goto out;
}
err = ocfs2_write_end_nolock(mapping, pos, len, len, fsdata);
- WARN_ON(err != len);
+ BUG_ON(err != len);
ret = VM_FAULT_LOCKED;
out:
return ret;
_