Re: [PATCH 32/39] vfs: fix freeze protection in mnt_want_write_file() for overlayfs

From: Christoph Hellwig
Date: Mon Jun 04 2018 - 04:50:13 EST


On Tue, May 29, 2018 at 04:43:32PM +0200, Miklos Szeredi wrote:
> The underlying real file used by overlayfs still contains the overlay path.
> This results in mnt_want_write_file() calls by the filesystem getting
> freeze protection on the wrong inode (the overlayfs one instead of the real
> one).
>
> Fix by using file_inode(file)->i_sb instead of file->f_path.mnt->mnt_sb.

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>