RE: [PATCH] mm: Add conditions to avoid out-of-bounds

From: Nixiaoming
Date: Mon Jun 04 2018 - 07:28:02 EST


I'm very sorry. It was my mistake.
it won't cross the border here.

Thanks


-----Original Message-----
From: Michal Hocko [mailto:mhocko@xxxxxxxxxx]
Sent: Monday, June 04, 2018 7:20 PM
To: Nixiaoming <nixiaoming@xxxxxxxxxx>
Cc: akpm@xxxxxxxxxxxxxxxxxxxx; vdavydov.dev@xxxxxxxxx; hannes@xxxxxxxxxxx; garsilva@xxxxxxxxxxxxxx; ktkhai@xxxxxxxxxxxxx; stummala@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx
Subject: Re: [PATCH] mm: Add conditions to avoid out-of-bounds

On Mon 04-06-18 18:37:35, nixiaoming wrote:
> In the function memcg_init_list_lru
> if call goto fail when i == 0, will cause out-of-bounds at lru->node[i]

How? All I can see is that the fail path does
for (i = i - 1; i >= 0; i--)

so it will not do anything for i=0.
--
Michal Hocko
SUSE Labs