Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header

From: Michal Hocko
Date: Mon Jun 04 2018 - 08:17:41 EST


On Mon 04-06-18 20:13:44, çèé wrote:
> Hi Michal
> I will add the missing information in the cover-letter.

I do not really think the cover letter needs much improvements. It is
the patch description that should be as specific as possible. Cover
letter should contain a highlevel description usually.

> > That being said, I am ready to ack a patch which adds the memcg of the
> > oom victim. I will not ack (nor nack) the patch which turns it into a
> > single print because I am not sure the benefit is really worth it. Maybe
> > others will though.
>
> OK, I will use the pr_cont_cgroup_name() to print origin and kill
> memcg's name. I hope David will not have other opinions :)

As I've said this can be always added on top pressuming there is a good
justification.
--
Michal Hocko
SUSE Labs