Re: [PATCH 03/19] sched/numa: Simplify load_too_imbalanced

From: Rik van Riel
Date: Mon Jun 04 2018 - 10:57:25 EST


On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
> Currently load_too_imbalance() cares about the slope of imbalance.
> It doesn't care of the direction of the imbalance.
>
> However this may not work if nodes that are being compared have
> dissimilar capacities. Few nodes might have more cores than other
> nodes
> in the system. Also unlike traditional load balance at a NUMA sched
> domain, multiple requests to migrate from the same source node to
> same
> destination node may run in parallel. This can cause huge load
> imbalance. This is specially true on a larger machines with either
> large
> cores per node or more number of nodes in the system. Hence allow
> move/swap only if the imbalance is going to reduce.

> Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>

--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part