RE: [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam

[Salil Mehta]

Hi Dave,
Thanks for pointing out. Will fix them.

Best regards
Salil

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Monday, June 04, 2018 4:36 PM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>; lipeng (Y)
> <lipeng321@xxxxxxxxxx>; mehta.salil@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Linuxarm <linuxarm@xxxxxxxxxx>; wangxi
> (M) <wangxi11@xxxxxxxxxx>
> Subject: Re: [PATCH net] net: hns: Fix the process of adding broadcast
> addresses to tcam
> 
> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Date: Fri, 1 Jun 2018 18:00:11 +0100
> 
> > +		hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > +			mc_mask, mac_entry->addr);
> 
> Please indent things properly when arguments span multiple lines.
> 
> The second line here should be precisely after the opennning
> parenthesis
> of the previous line.
> 
> > +		hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > +			mc_mask, mac_entry->addr);
> 
> Likewise.