Re: [PATCH 1/3] mfd: cros: add charger port count command definition

From: Lee Jones
Date: Tue Jun 05 2018 - 03:11:30 EST


On Mon, 04 Jun 2018, Fabien Parent wrote:

> On Mon, Jun 4, 2018 at 1:59 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > On Tue, 29 May 2018, Fabien Parent wrote:
> >
> >> A new more command has been added to the ChromeOS embedded controller
> >> that allows to get the number of charger port count. Unlike
> >> EC_CMD_USB_PD_PORTS, this new command also includes the dedicated
> >> port if present.
> >>
> >> This command will be used to expose the dedicated charger port
> >> in the ChromeOS charger driver.
> >>
> >> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> >> ---
> >> include/linux/mfd/cros_ec_commands.h | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >
> > Does not want to apply. I didn't investigate why.
> >
> > Please rebase and resend?
>
> Sorry, I forgot to add you as "to:" to the patch series.
> This patch applies on top of https://lkml.org/lkml/2018/5/2/590
> ([PATCH v4 1/3] mfd: cros_ec: Add USBPD charger commands and struct
> definitions)

Okay. Please re-submit after that set has landed then.

Please, also add my Ack to the patch:

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog