Re: [PATCH] r8169: Reinstate ALDPS and ASPM support

From: Florian Fainelli
Date: Tue Jun 05 2018 - 12:47:34 EST


On 06/05/2018 07:15 AM, David Miller wrote:
> From: Andrew Lunn <andrew@xxxxxxx>
> Date: Tue, 5 Jun 2018 16:11:14 +0200
>
>> No module parameter please. Just turn it on by default. Assuming
>> testing shows works.
>
> Agreed.

devlink would be a good candidate to add such configuration attributes,
since you would be operating on the PCI function itself, thus allowing
this to be on a per-device instance basis as opposed to global, which is
what a module parameter is.
--
Florian